Github user interma commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/1274#discussion_r131585776
  
    --- Diff: depends/libhdfs3/src/client/InputStreamImpl.cpp ---
    @@ -626,6 +645,12 @@ int32_t InputStreamImpl::readInternal(char * buf, 
int32_t size) {
     
                     continue;
                 }
    +            std::string bufDecode;
    +            if (fileStatus.isFileEncrypted()) {
    +                /* Decrypt buffer if the file is encrypted. */
    +                bufDecode = cryptoCodec->cipher_wrap(buf, size);
    +                memcpy(buf, bufDecode.c_str(), size);
    --- End diff --
    
    must use `retval` instead of `size` here, because `readOneBlock()` doesn't 
always give "size" bytes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to