Github user shivzone commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/1289#discussion_r140363109
  
    --- Diff: src/backend/access/external/pxfheaders.c ---
    @@ -65,14 +65,18 @@ void build_http_header(PxfInputData *input)
        
        if (proj_info != NULL && proj_info->pi_isVarList)
        {
    -           List* qualsAttributes = extractPxfAttributes(input->quals);
    +           bool qualsAreSupported = true;
    +           List* qualsAttributes = extractPxfAttributes(input->quals, 
&qualsAreSupported);
    --- End diff --
    
    qualsAreSupported seems redundant. Is there any scneario when 
qualsAttributes is not null when we don't want to support projection info ?


---

Reply via email to