Github user sansanichfb commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1289#discussion_r140389383 --- Diff: src/backend/access/external/pxffilters.c --- @@ -851,12 +852,51 @@ append_attr_from_var(Var* var, List* attrs) return attrs; } +/* + * append_attr_from_func_args + * + * extracts all columns from FuncExpr into attrs + * assigns false to expressionIsSupported if at least one of items is not supported + */ +static List* +append_attr_from_func_args(FuncExpr *expr, List* attrs, bool* expressionIsSupported) { + ListCell *lc = NULL; + if (!expressionIsSupported) { --- End diff -- Sure, updated
---