Github user denalex commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1294#discussion_r142534056
--- Diff: pxf/pxf-service/src/scripts/pxf-env.sh ---
@@ -34,7 +34,11 @@ export PXF_LOGDIR=@pxfLogDir@
export PXF_RUNDIR=@pxfRunDir@
# Configured user
-export PXF_USER=${PXF_USER:-@pxfDefaultUser@}
+if [ ! -z "@pxfDefaultUser@" ]; then
--- End diff --
these conditions will look really weird in the generated script, would it
be better to assign this to variable, which gets filtered value and then check
the value of that variable in all the if statements.
---
