Github user shivzone commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/1294#discussion_r142801258
  
    --- Diff: pxf/pxf-service/src/scripts/pxf-service ---
    @@ -35,9 +35,14 @@ else
        source $env_script
     fi
     
    -pxf_user=${PXF_USER:-pxf}
    +pxf_user=${PXF_USER}
     instance_port=${PXF_PORT:-51200}
     instance_name=pxf-service
    +if [ ! -z '@pxfDefaultUser@' ]; then
    --- End diff --
    
    Similar suggestion here. Lets not introduce additional variable 
allow_custom_pxf_user and simply make leverage pxf_user variable directly


---

Reply via email to