[
https://issues.apache.org/jira/browse/HBASE-1200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12869329#action_12869329
]
stack commented on HBASE-1200:
------------------------------
Nicolas:
{code}
// For each file, obtain a scanner:
- List<KeyValueScanner> scanners = StoreFileScanner.getScannersForStoreFiles(
- filesToCompact, false, false);
+ List<StoreFileScanner> sfScanners = StoreFileScanner
+ .getScannersForStoreFiles(filesToCompact, false, false);
+ List<KeyValueScanner> scanners =
+ new ArrayList<KeyValueScanner>(sfScanners.size()+1);
{code}
Something wrong in the above. We make new scanners List but we don't add the
sfScanners to it that I can see.
> Add bloomfilters
> ----------------
>
> Key: HBASE-1200
> URL: https://issues.apache.org/jira/browse/HBASE-1200
> Project: Hadoop HBase
> Issue Type: Task
> Affects Versions: 0.20.5
> Reporter: stack
> Assignee: Nicolas Spiegelberg
> Fix For: 0.21.0
>
> Attachments: 1200-trunk.txt, Bloom Filters in HBase.docx,
> Bloom_Filters_in_HBase.pdf, HBASE-1200-0.20.5-4.patch,
> HBASE-1200-0.20.5.patch, hbase-1200-0.20branch-v2.txt,
> ryan_bloomfilter.patch, Store.java.rej, StoreScanner.java.rej
>
>
> Add bloomfiltering to hfile. Can be enabled on a family-level basis.
> Ability to configure a row vs row+col level bloom. We size the bloomfilter
> with the number of entries we are about to flush which seems like usually
> we'd be making a filter too big, so our implementation needs to take that
> into account.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
