[
https://issues.apache.org/jira/browse/HBASE-1200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12870951#action_12870951
]
stack commented on HBASE-1200:
------------------------------
.bq The only unaddressed issue was the Array.add for Row+Col filters. Figure we
can put that into a seperate JIRA if need be.
Nicolas, what was this issue? I tried grepping the comments for Array.add. Is
it this?
{code}
branches/0.20/src/java/org/apache/hadoop/hbase/regionserver/StoreFile.java
(Diff revision 1)
663
key = Bytes.add(row, col);
this seems like it could get moderately expensive.
since the bloom filter is just going to be calculating hashes of the bytes,
could the API be modified a bit to take a List<ByteBuffer> or something else
that allowed it to calculate the hash across a concatenation of byte arrays?
Nicolas 2 weeks, 1 day ago (May 9th, 2010, 4:25 p.m.)
this was a last-minute addition for the 2248 refactoring. can revisit/optimize
{code}
I'd like to make an issue for whatever it was. Thanks.
> Add bloomfilters
> ----------------
>
> Key: HBASE-1200
> URL: https://issues.apache.org/jira/browse/HBASE-1200
> Project: HBase
> Issue Type: Task
> Affects Versions: 0.20.5
> Reporter: stack
> Assignee: Nicolas Spiegelberg
> Fix For: 0.21.0
>
> Attachments: 1200-trunk.txt, Bloom Filters in HBase.docx,
> Bloom_Filters_in_HBase.pdf, HBASE-1200-0.20.5-4.patch,
> HBASE-1200-0.20.5.patch, hbase-1200-0.20branch-v2.txt,
> ryan_bloomfilter.patch, Store.java.rej, StoreScanner.java.rej
>
>
> Add bloomfiltering to hfile. Can be enabled on a family-level basis.
> Ability to configure a row vs row+col level bloom. We size the bloomfilter
> with the number of entries we are about to flush which seems like usually
> we'd be making a filter too big, so our implementation needs to take that
> into account.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
