[
https://issues.apache.org/jira/browse/HBASE-2838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12891869#action_12891869
]
HBase Review Board commented on HBASE-2838:
-------------------------------------------
Message from: "Jean-Daniel Cryans" <[email protected]>
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/381/
-----------------------------------------------------------
Review request for hbase.
Summary
-------
Added the basic metrics, currently only accessible via hadoop metrics. Metrics
maintenance is done inline using ReplicationMetrics as a Singleton, wanted to
get others opinion on that.
If we are to cut a 0.89 soon, at least this patch needs to go in IMO.
This addresses bug HBASE-2838.
http://issues.apache.org/jira/browse/HBASE-2838
Diffs
-----
src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationMetrics.java
PRE-CREATION
src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSink.java
3eec1d7
src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java
855cd6f
src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceManager.java
0501048
src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationStatistics.java
PRE-CREATION
src/test/java/org/apache/hadoop/hbase/replication/TestReplication.java
28a6e51
Diff: http://review.hbase.org/r/381/diff
Testing
-------
Unit tests
Thanks,
Jean-Daniel
> Replication metrics
> -------------------
>
> Key: HBASE-2838
> URL: https://issues.apache.org/jira/browse/HBASE-2838
> Project: HBase
> Issue Type: Sub-task
> Reporter: Jean-Daniel Cryans
> Assignee: Jean-Daniel Cryans
> Fix For: 0.90.0
>
>
> Replication needs to publish metrics about its performance:
> - WALEdits read, filtered, sent to slave clusters, applied on slaves
> - size of batches sent/received
> - ms spent on reading, sending, applying edits
> This can be done using HadoopMetrics.
> Also we need to publish information not related to performance:
> - size of each HLog queues
> - age of the last replicated edit in each queue
> - time of last successful replication
> These informations can hardly be graphed, but we still need to represent them
> somehow. It has to be accessible by web UI, shell, and other tools in
> general. I don't feel strongly about creating a new public method on HRS's
> interface, and I'm not sure publishing those in ZooKeeper is a good idea
> either (why add another indirection?). Still wondering about a better
> solution.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
