[
https://issues.apache.org/jira/browse/HBASE-2838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12892558#action_12892558
]
HBase Review Board commented on HBASE-2838:
-------------------------------------------
Message from: "Jean-Daniel Cryans" <[email protected]>
bq. On 2010-07-24 21:01:02, stack wrote:
bq. >
src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSink.java,
line 142
bq. > <http://review.hbase.org/r/381/diff/1/?file=3223#file3223line142>
bq. >
bq. > There will always be edits if we get this far? (I'm wondering if
ever a illegalAccessException possible here)
bq. >
I'll put a safeguard at the beginning of the method to ensure we have a least 1
entry. It should always be the case... but you never
bq. On 2010-07-24 21:01:02, stack wrote:
bq. >
src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java,
line 504
bq. > <http://review.hbase.org/r/381/diff/1/?file=3224#file3224line504>
bq. >
bq. > Should this be 'notted'? You want to count when row keys are not
the same?
/me facedesk
bq. On 2010-07-24 21:01:02, stack wrote:
bq. >
src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationStatistics.java,
line 32
bq. > <http://review.hbase.org/r/381/diff/1/?file=3226#file3226line32>
bq. >
bq. > Do you have to do this to make them show in JMX? I didn't know.
No idea, but the rest of the metrics stuff is done like that...
bq. On 2010-07-24 21:01:02, stack wrote:
bq. > src/test/java/org/apache/hadoop/hbase/replication/TestReplication.java,
line 183
bq. > <http://review.hbase.org/r/381/diff/1/?file=3227#file3227line183>
bq. >
bq. > What this? Reenabling tests?
they were disabled in another commit inadvertently, re-enabling.
bq. On 2010-07-24 21:01:02, stack wrote:
bq. >
src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationMetrics.java,
line 42
bq. > <http://review.hbase.org/r/381/diff/1/?file=3222#file3222line42>
bq. >
bq. > For sure these metrics show fine in ganglia? Whats the prefix that
they show up under? Is there one? (Looks like its hbase? Thats OK i'd say.
Should prefix have replication in it somewhere though?)
It is prefixed with hbase.replication automatically.
- Jean-Daniel
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/381/#review481
-----------------------------------------------------------
> Replication metrics
> -------------------
>
> Key: HBASE-2838
> URL: https://issues.apache.org/jira/browse/HBASE-2838
> Project: HBase
> Issue Type: Sub-task
> Reporter: Jean-Daniel Cryans
> Assignee: Jean-Daniel Cryans
> Fix For: 0.90.0
>
>
> Replication needs to publish metrics about its performance:
> - WALEdits read, filtered, sent to slave clusters, applied on slaves
> - size of batches sent/received
> - ms spent on reading, sending, applying edits
> This can be done using HadoopMetrics.
> Also we need to publish information not related to performance:
> - size of each HLog queues
> - age of the last replicated edit in each queue
> - time of last successful replication
> These informations can hardly be graphed, but we still need to represent them
> somehow. It has to be accessible by web UI, shell, and other tools in
> general. I don't feel strongly about creating a new public method on HRS's
> interface, and I'm not sure publishing those in ZooKeeper is a good idea
> either (why add another indirection?). Still wondering about a better
> solution.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
