[
https://issues.apache.org/jira/browse/HBASE-2792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12891973#action_12891973
]
HBase Review Board commented on HBASE-2792:
-------------------------------------------
Message from: "Chongxin Li" <[email protected]>
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/372/
-----------------------------------------------------------
(Updated 2010-07-24 05:10:08.798554)
Review request for hbase.
Changes
-------
Since currently there are only two log cleaners (TimeToLiveLogCleaner and
ReplicationLogCleaner) in the chain, there would be 3 scenarios, that is log
file doesn't pass the first log cleaner; log file passes the first log cleaner
but is rejected by the second; log file passes both log cleaners and is then
deleted. I think these 3 cases are all covered by the unit test. I've added
some comments to the unit test to explain these 3 cases.
Summary
-------
HBASE-2792: Create a better way to chain log cleaners
This addresses bug HBASE-2792.
http://issues.apache.org/jira/browse/HBASE-2792
Diffs (updated)
-----
src/main/java/org/apache/hadoop/hbase/master/LogCleanerDelegate.java 3ca3611
src/main/java/org/apache/hadoop/hbase/master/LogsCleaner.java 37b2c3c
src/main/java/org/apache/hadoop/hbase/master/ServerManager.java 9fb1cce
src/main/java/org/apache/hadoop/hbase/replication/master/ReplicationLogCleaner.java
eb859aa
src/main/resources/hbase-default.xml e3a9669
src/test/java/org/apache/hadoop/hbase/master/TestLogsCleaner.java a92e0da
Diff: http://review.hbase.org/r/372/diff
Testing
-------
Unit test TestOldLogsCleaner passed.
Thanks,
Chongxin
> Create a better way to chain log cleaners
> -----------------------------------------
>
> Key: HBASE-2792
> URL: https://issues.apache.org/jira/browse/HBASE-2792
> Project: HBase
> Issue Type: Improvement
> Reporter: Jean-Daniel Cryans
> Assignee: Li Chongxin
> Fix For: 0.90.0
>
>
> From Stack's review of HBASE-2223:
> {quote}
> Why this implementation have to know about other implementations? Can't we
> do a chain of decision classes? Any class can say no? As soon as any
> decision class says no, we exit the chain.... So in this case, first on the
> chain would be the ttl decision... then would be this one... and third would
> be the snapshotting decision. You don't have to do the chain as part of this
> patch but please open an issue to implement.
> {quote}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
