[ 
https://issues.apache.org/jira/browse/HBASE-2792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12892840#action_12892840
 ] 

HBase Review Board commented on HBASE-2792:
-------------------------------------------

Message from: [email protected]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/372/#review496
-----------------------------------------------------------

Ship it!


+1

Will commit in a little while.

- stack





> Create a better way to chain log cleaners
> -----------------------------------------
>
>                 Key: HBASE-2792
>                 URL: https://issues.apache.org/jira/browse/HBASE-2792
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Jean-Daniel Cryans
>            Assignee: Li Chongxin
>             Fix For: 0.90.0
>
>
> From Stack's review of HBASE-2223:
> {quote}
> Why this implementation have to know about other implementations?  Can't we 
> do a chain of decision classes? Any class can say no?  As soon as any 
> decision class says no, we exit the chain.... So in this case, first on the 
> chain would be the ttl decision... then would be this one... and third would 
> be the snapshotting decision. You don't have to do the chain as part of this 
> patch but please open an issue to implement.
> {quote}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to