[ 
https://issues.apache.org/jira/browse/HBASE-2887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12893426#action_12893426
 ] 

HBase Review Board commented on HBASE-2887:
-------------------------------------------

Message from: "Todd Lipcon" <[email protected]>

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/418/
-----------------------------------------------------------

Review request for hbase, stack, dhruba borthakur, and Kannan Muthukkaruppan.


Summary
-------

Bunch of changes to the HBaseFsck tool to detect a wider variety of issues and 
to make it easier to add "fix" support for these problems in the future.


This addresses bug HBASE-2887.
    http://issues.apache.org/jira/browse/HBASE-2887


Diffs
-----

  src/main/java/org/apache/hadoop/hbase/client/HBaseFsck.java 19cdec1 
  src/main/java/org/apache/hadoop/hbase/client/MetaScanner.java 5f8b909 
  src/test/java/org/apache/hadoop/hbase/client/TestHBaseFsck.java PRE-CREATION 

Diff: http://review.cloudera.org/r/418/diff


Testing
-------

Tested an earlier variation of this patch against my cluster in various screwed 
up states. This patch adds a basic unit test but it could be improved to use a 
mock cluster and test more variations.


Thanks,

Todd




> Improvements and refactor for HBaseFsck tool
> --------------------------------------------
>
>                 Key: HBASE-2887
>                 URL: https://issues.apache.org/jira/browse/HBASE-2887
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 0.90.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>
> Refactored the way the HBaseFsck tool works -- it now loads all the info it 
> can find into RAM first, and then looks over the in-memory structures for 
> inconsistencies. It's still a work in progress, but detects more kinds of 
> problems now (eg multiple assignment, etc) and has some very basic functional 
> tests.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to