[
https://issues.apache.org/jira/browse/HBASE-2887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12893512#action_12893512
]
HBase Review Board commented on HBASE-2887:
-------------------------------------------
Message from: [email protected]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/418/#review533
-----------------------------------------------------------
Ship it!
Looks great to me. Few comments below.
src/main/java/org/apache/hadoop/hbase/client/HBaseFsck.java
<http://review.cloudera.org/r/418/#comment2127>
How do I supply different implementation of ErrorReporter?
src/main/java/org/apache/hadoop/hbase/client/HBaseFsck.java
<http://review.cloudera.org/r/418/#comment2128>
What about logs dir and old logs dir -- we skipping them here?
src/test/java/org/apache/hadoop/hbase/client/TestHBaseFsck.java
<http://review.cloudera.org/r/418/#comment2130>
White space. Better remove it if you'd avoid wrath of Benôit.
- stack
> Improvements and refactor for HBaseFsck tool
> --------------------------------------------
>
> Key: HBASE-2887
> URL: https://issues.apache.org/jira/browse/HBASE-2887
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
>
> Refactored the way the HBaseFsck tool works -- it now loads all the info it
> can find into RAM first, and then looks over the in-memory structures for
> inconsistencies. It's still a work in progress, but detects more kinds of
> problems now (eg multiple assignment, etc) and has some very basic functional
> tests.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
