[ 
https://issues.apache.org/jira/browse/HBASE-2980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12908061#action_12908061
 ] 

HBase Review Board commented on HBASE-2980:
-------------------------------------------

Message from: [email protected]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/812/#review1151
-----------------------------------------------------------

Ship it!


+1


src/main/java/org/apache/hadoop/hbase/master/HMasterCommandLine.java
<http://review.cloudera.org/r/812/#comment3968>

    Daemon is a good name but maybe use the not so good 'ServerCommandLine' so 
it aligns w/ the new Server Interface we extracted from Master and RS
    
    Or we could change the 'Server' Interface name to Daemon?


- stack





> Refactor HRegionServer command line parsing
> -------------------------------------------
>
>                 Key: HBASE-2980
>                 URL: https://issues.apache.org/jira/browse/HBASE-2980
>             Project: HBase
>          Issue Type: Task
>          Components: regionserver
>    Affects Versions: 0.90.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Minor
>             Fix For: 0.90.0
>
>
> Similar to HBASE-2977, refactor the command line parsing logic out of the 
> HRegionServer class.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to