[
https://issues.apache.org/jira/browse/HBASE-2980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12908921#action_12908921
]
HBase Review Board commented on HBASE-2980:
-------------------------------------------
Message from: "Todd Lipcon" <[email protected]>
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/812/
-----------------------------------------------------------
(Updated 2010-09-13 11:29:19.499500)
Review request for hbase, stack and Jonathan Gray.
Changes
-------
Updated diff, renames DaemonCommandLine to ServerCommandLine. Also I realized I
forgot to include DaemonCommandLine in the diff last time, so should probably
have someone look that over.
Summary
-------
Same as HBASE-2977 but from the master side
This addresses bug HBASE-2980.
http://issues.apache.org/jira/browse/HBASE-2980
Diffs (updated)
-----
src/main/java/org/apache/hadoop/hbase/master/HMaster.java 792fb3e
src/main/java/org/apache/hadoop/hbase/master/HMasterCommandLine.java 6421808
src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 1e046f9
src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServerCommandLine.java
PRE-CREATION
src/main/java/org/apache/hadoop/hbase/util/ServerCommandLine.java
PRE-CREATION
src/test/java/org/apache/hadoop/hbase/master/OOMEHMaster.java b51e6ab
src/test/java/org/apache/hadoop/hbase/regionserver/OOMERegionServer.java
c591632
Diff: http://review.cloudera.org/r/812/diff
Testing
-------
Started a region server, also checked usage info for a bad param.
Thanks,
Todd
> Refactor HRegionServer command line parsing
> -------------------------------------------
>
> Key: HBASE-2980
> URL: https://issues.apache.org/jira/browse/HBASE-2980
> Project: HBase
> Issue Type: Task
> Components: regionserver
> Affects Versions: 0.90.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Minor
> Fix For: 0.90.0
>
>
> Similar to HBASE-2977, refactor the command line parsing logic out of the
> HRegionServer class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
