[
https://issues.apache.org/jira/browse/HBASE-2935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12919701#action_12919701
]
Nicolas Spiegelberg commented on HBASE-2935:
--------------------------------------------
3 tests were removed, so this jira is about evaluating whether we should add
them back in and to what extent. My suggestion is to run a system-level test,
where we corrupt at the HDFS level and ensure that everything percolate up and
gets handled properly. Just throwing a ChecksumException is fine to simply
test the splitLog() logic but defeats the previous idea that Cosmin had of
actually corrupting the underlying file data.
> Refactor "Corrupt Data" Tests in TestHLogSplit
> ----------------------------------------------
>
> Key: HBASE-2935
> URL: https://issues.apache.org/jira/browse/HBASE-2935
> Project: HBase
> Issue Type: Bug
> Components: test
> Affects Versions: 0.89.20100621
> Reporter: Nicolas Spiegelberg
> Priority: Minor
>
> While fixing HBASE-2643, I noticed that a couple of the HLogSplit tests from
> HBASE-2437 were now failing. 3 tests are trying to detect proper handling of
> garbage data: testCorruptedFileGetsArchivedIfSkipErrors,
> testTrailingGarbageCorruptionLogFileSkipErrorsFalseThrows,
> testCorruptedLogFilesSkipErrorsFalseDoesNotTouchLogs. However, these tests
> are corrupting data at the HBase level. Data corruption should be tested at
> the HDFS level, because the filesystem is responsible for data validation.
> These tests need to inject corrupt data at the HDFS level & then verify that
> ChecksumExceptions are thrown.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
