[
https://issues.apache.org/jira/browse/HBASE-2935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12926440#action_12926440
]
HBase Review Board commented on HBASE-2935:
-------------------------------------------
Message from: "Alex Newman" <[email protected]>
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1115/
-----------------------------------------------------------
(Updated 2010-10-29 13:24:54.726844)
Review request for hbase and Nicolas.
Summary
-------
So I took the approach taken with the instrumented sequence file rider. Not
sure if exposing those methods in the WALReader is cool so I am down with other
suggestions.
- Add a FaultySequenceFileLogReader
- Un-commented the 2935 tests
This addresses bug hbase-2935.
http://issues.apache.org/jira/browse/hbase-2935
Diffs
-----
src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java c8a10af
src/main/java/org/apache/hadoop/hbase/regionserver/wal/SequenceFileLogReader.java
0b7dc78
src/test/java/org/apache/hadoop/hbase/regionserver/wal/FaultySequenceFileLogReader.java
PRE-CREATION
src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLogSplit.java
473c359
Diff: http://review.cloudera.org/r/1115/diff
Testing
-------
Running on our internal hudson as I type this. Also I ran the TestHLogSplit
test locally. I'll update the review if hudson is green.
Thanks,
Alex
> Refactor "Corrupt Data" Tests in TestHLogSplit
> ----------------------------------------------
>
> Key: HBASE-2935
> URL: https://issues.apache.org/jira/browse/HBASE-2935
> Project: HBase
> Issue Type: Bug
> Components: test
> Affects Versions: 0.89.20100621
> Reporter: Nicolas Spiegelberg
> Assignee: Alex Newman
> Priority: Minor
> Attachments:
> 0001-HBASE-2935.-fix-testCorruptedFileGetsArchivedIfSkipE.patch
>
>
> While fixing HBASE-2643, I noticed that a couple of the HLogSplit tests from
> HBASE-2437 were now failing. 3 tests are trying to detect proper handling of
> garbage data: testCorruptedFileGetsArchivedIfSkipErrors,
> testTrailingGarbageCorruptionLogFileSkipErrorsFalseThrows,
> testCorruptedLogFilesSkipErrorsFalseDoesNotTouchLogs. However, these tests
> are corrupting data at the HBase level. Data corruption should be tested at
> the HDFS level, because the filesystem is responsible for data validation.
> These tests need to inject corrupt data at the HDFS level & then verify that
> ChecksumExceptions are thrown.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
