[ 
https://issues.apache.org/jira/browse/HBASE-2946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12924728#action_12924728
 ] 

HBase Review Board commented on HBASE-2946:
-------------------------------------------

Message from: "Jonathan Gray" <[email protected]>


bq.  On 2010-10-24 21:41:48, khemani wrote:
bq.  > trunk/src/main/java/org/apache/hadoop/hbase/client/Increment.java, line 
45
bq.  > <http://review.cloudera.org/r/1088/diff/2/?file=15904#file15904line45>
bq.  >
bq.  >     setWriteToWal() is missing?

yup.  will add.


bq.  On 2010-10-24 21:41:48, khemani wrote:
bq.  > trunk/src/main/java/org/apache/hadoop/hbase/client/Increment.java, lines 
46-47
bq.  > <http://review.cloudera.org/r/1088/diff/2/?file=15904#file15904line46>
bq.  >
bq.  >     why a navigable map? why not just a map?

u can do things like tailMap[() with it.


bq.  On 2010-10-24 21:41:48, khemani wrote:
bq.  > trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java, 
line 3012
bq.  > <http://review.cloudera.org/r/1088/diff/2/?file=15907#file15907line3012>
bq.  >
bq.  >     I am not sure how it is ensured that the order of iteration over the 
columns in family.getValue.entrySet() is same as the order of results returned?
bq.  >     
bq.  >     Also, if get finds multiple matches then will it return all of them? 
If yes then this will not work.

familyMap and the map of columns to amounts are both TreeMaps ordered with 
Bytes.BYTES_COMPARATOR.  Results are also guaranteed to be in order.  And our 
Get has maxVersions=1 so we will not get multiple matches per column.





> Increment multiple columns in a row at once
> -------------------------------------------
>
>                 Key: HBASE-2946
>                 URL: https://issues.apache.org/jira/browse/HBASE-2946
>             Project: HBase
>          Issue Type: New Feature
>          Components: client, regionserver
>            Reporter: Jonathan Gray
>            Assignee: Jonathan Gray
>
> Currently there is no way to do multiple increments to a single row in one 
> RPC.  This jira is about adding an HTable and HRegionInterface method to 
> increment multiple columns within a single row at once.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to