[ 
https://issues.apache.org/jira/browse/HBASE-2946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12924753#action_12924753
 ] 

HBase Review Board commented on HBASE-2946:
-------------------------------------------

Message from: "Ryan Rawson" <[email protected]>

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1088/#review1660
-----------------------------------------------------------



trunk/src/main/java/org/apache/hadoop/hbase/regionserver/MemStore.java
<http://review.cloudera.org/r/1088/#comment5541>

    your logic is correct, and normally this is an issue, but there is this 
line a few down:
    
    
                now = Math.max(now, kv.getTimestamp());
    
    
    I havent played with the new sorting thing, the big problem is you get lost 
updates via ICV if things dont go right.  
    
    I just had a notion, when we do the 'get from memstore first' how do we 
handle duplicate TSs in snapshot and kvset... looking at the memstore scanner, 
i see this:
    
    
          return getLower(kvsetNextRow,
              snapshotNextRow);
    
    and inside the implementation of getLower(), we return 'kvsetNextRow' when 
the two compare to the same. So it should be ok. If it doesn't work out, the 
worst case scenario is probably losing 1ms worth of updates.


- Ryan





> Increment multiple columns in a row at once
> -------------------------------------------
>
>                 Key: HBASE-2946
>                 URL: https://issues.apache.org/jira/browse/HBASE-2946
>             Project: HBase
>          Issue Type: New Feature
>          Components: client, regionserver
>            Reporter: Jonathan Gray
>            Assignee: Jonathan Gray
>
> Currently there is no way to do multiple increments to a single row in one 
> RPC.  This jira is about adding an HTable and HRegionInterface method to 
> increment multiple columns within a single row at once.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to