[ 
https://issues.apache.org/jira/browse/HBASE-3160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12925631#action_12925631
 ] 

HBase Review Board commented on HBASE-3160:
-------------------------------------------

Message from: "Nicolas" <[email protected]>

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1103/#review1684
-----------------------------------------------------------



trunk/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreFlusher.java
<http://review.cloudera.org/r/1103/#comment5585>

    never mind.  my fault for inverting the conditional logic.  this is the 
correct logic.  if (isTooManyStorefiles() == true) region.getCompactPriority() 
<= 0, so we're okay


- Nicolas





> Compactions: Use more intelligent priorities for PriorityCompactionQueue
> ------------------------------------------------------------------------
>
>                 Key: HBASE-3160
>                 URL: https://issues.apache.org/jira/browse/HBASE-3160
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 0.89.20100924, 0.90.0
>            Reporter: Nicolas Spiegelberg
>            Assignee: Nicolas Spiegelberg
>             Fix For: 0.90.0
>
>
> One of the problems with the current compaction queue is that we have a very 
> low granularity on the importance of the various compactions in the queue.  
> If a StoreFile count exceeds 15 files, only then do we bump via enum change.  
> We should instead look into more intelligent, granular priority metrics for 
> choosing the next compaction.  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to