[
https://issues.apache.org/jira/browse/HBASE-3160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12926176#action_12926176
]
HBase Review Board commented on HBASE-3160:
-------------------------------------------
Message from: "Nicolas" <[email protected]>
bq. On 2010-10-28 22:04:28, Ted Yu wrote:
bq. > trunk/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java,
line 1333
bq. > <http://review.cloudera.org/r/1103/diff/2/?file=16199#file16199line1333>
bq. >
bq. > It is possible to return a negative priority here.
that is correct. the 0 is centered around the blocking limit. I added a test
to ensure that we can properly handle negative priorities and prioritize the
most negative value @ TestPriorityCompactionQueue.java:308 . Note that the
code to handle priorities in the heap is @ PriorityCompactionQueue.java:89
bq. On 2010-10-28 22:04:28, Ted Yu wrote:
bq. > trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java,
line 3258
bq. > <http://review.cloudera.org/r/1103/diff/2/?file=16195#file16195line3258>
bq. >
bq. > Seems to be typo here.
bq. > Should be: this region should have
will fix
- Nicolas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1103/#review1698
-----------------------------------------------------------
> Compactions: Use more intelligent priorities for PriorityCompactionQueue
> ------------------------------------------------------------------------
>
> Key: HBASE-3160
> URL: https://issues.apache.org/jira/browse/HBASE-3160
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.89.20100924, 0.90.0
> Reporter: Nicolas Spiegelberg
> Assignee: Nicolas Spiegelberg
> Fix For: 0.90.0
>
>
> One of the problems with the current compaction queue is that we have a very
> low granularity on the importance of the various compactions in the queue.
> If a StoreFile count exceeds 15 files, only then do we bump via enum change.
> We should instead look into more intelligent, granular priority metrics for
> choosing the next compaction.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
