[ 
https://issues.apache.org/jira/browse/HBASE-3387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12974373#action_12974373
 ] 

Jesse Yates commented on HBASE-3387:
------------------------------------

Stack, I see what you are saying about the && vs ||. I think the original way 
involves and extra line (was shooting or concise), but I prefer your way; I'll 
switch it up.

Sorry about the reformatting- old eclipse autoformat habits die hard- though I 
was using trying to use the hbase std format. Do you want me to switch it back 
to the old version or just keep it?

> Pair does not deep check arrays for equality. 
> ----------------------------------------------
>
>                 Key: HBASE-3387
>                 URL: https://issues.apache.org/jira/browse/HBASE-3387
>             Project: HBase
>          Issue Type: Bug
>          Components: util
>    Affects Versions: 0.90.1
>         Environment: Any (discovered in Ubuntu 10.10 using TRUNK). 
>            Reporter: Jesse Yates
>            Priority: Minor
>             Fix For: 0.90.1
>
>         Attachments: HBASE-3387.patch
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> Pair does not deep check arrays for equality. It merely does x.equals(y) for 
> the sent Object. However, with any type of array this is merely going to 
> compare the array pointers, rather than the underlying data structure.
> It requires a rewriting of the private equals method in Pair to check for 
> elements being an array, then checking the underlying elements.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to