[ 
https://issues.apache.org/jira/browse/HBASE-3387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12975634#action_12975634
 ] 

stack commented on HBASE-3387:
------------------------------

@Jesse When I try to apply this patch I get this:

{code}
stack:trunk Stack$ patch -p1 < HBASE-3387.patch 
patching file src/main/java/org/apache/hadoop/hbase/util/Pair.java
patch: **** malformed patch at line 34:   * @param <T1>
{code}

Does it apply for you?

> Pair does not deep check arrays for equality. 
> ----------------------------------------------
>
>                 Key: HBASE-3387
>                 URL: https://issues.apache.org/jira/browse/HBASE-3387
>             Project: HBase
>          Issue Type: Bug
>          Components: util
>    Affects Versions: 0.90.1
>         Environment: Any (discovered in Ubuntu 10.10 using TRUNK). 
>            Reporter: Jesse Yates
>            Priority: Minor
>             Fix For: 0.90.1
>
>         Attachments: HBASE-3387.patch
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> Pair does not deep check arrays for equality. It merely does x.equals(y) for 
> the sent Object. However, with any type of array this is merely going to 
> compare the array pointers, rather than the underlying data structure.
> It requires a rewriting of the private equals method in Pair to check for 
> elements being an array, then checking the underlying elements.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to