[
https://issues.apache.org/jira/browse/HBASE-8782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13692812#comment-13692812
]
Lars George commented on HBASE-8782:
------------------------------------
Hi [~madani], thanks for the patch. One more nit:
- Change getTable()
Could you please change (or add an additional *if* required)
ThriftHBaseServiceHandler.getTable() to take the ByteBuffer directly and then
in there call the byteBufferToByteArray() method. That keeps the code cleaner
and more concise.
Oh, and you do *not* have to edit the JIRA issue when you attach a new patch
etc. JIRA tracks all of these events nicely already. As you may be aware,
clicking on the "Activities - All" tab shows when you uploaded what patch in a
time ordered list of records.
And as for HBASE-8774, yes, will do so, I am ramping up my Thrift support from
the committer side, i.e. I have taken on to work on all related issues. Please
keep them coming!
Thanks, Lars
> Thrift2 can not parse values when using framed transport
> --------------------------------------------------------
>
> Key: HBASE-8782
> URL: https://issues.apache.org/jira/browse/HBASE-8782
> Project: HBase
> Issue Type: Bug
> Components: Thrift
> Affects Versions: 0.95.1
> Reporter: Hamed Madani
> Attachments: HBASE_8782.patch, HBASE_8782_v2.patch
>
>
> ThriftHBaseServiceHandler.java use .array() on table names , and values
> (family , qualifier in checkandDelete , etc) which resulted in incorrect
> values with framed transport. Replacing .array() with getBytes() fixed this
> problem. I've attached the patch
> EDIT: updated the patch to cover checkAndPut(), checkAndDelete()
> UPDATE: updated the patch to use *byteBufferToByteArray()* instead of
> *getBytes()* , also removed unused imports.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
