[ 
https://issues.apache.org/jira/browse/HBASE-8782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13692859#comment-13692859
 ] 

Lars George commented on HBASE-8782:
------------------------------------

[~madani] could you kindly do one more patch with line lengths less than 100 
characters as per the above QA run? If you are at it, could you please also 
wrap the other few larger lines as well. Otherwise looks good to me, I will 
commit the next patch then.
                
> Thrift2 can not parse values when using framed transport
> --------------------------------------------------------
>
>                 Key: HBASE-8782
>                 URL: https://issues.apache.org/jira/browse/HBASE-8782
>             Project: HBase
>          Issue Type: Bug
>          Components: Thrift
>    Affects Versions: 0.95.1
>            Reporter: Hamed Madani
>            Assignee: Hamed Madani
>         Attachments: HBASE_8782.patch, HBASE_8782_v2.patch, 
> HBASE_8782_v3.patch
>
>
> ThriftHBaseServiceHandler.java use .array() on table names , and values 
> (family , qualifier in checkandDelete , etc) which resulted in incorrect 
> values with framed transport. Replacing .array() with getBytes() fixed this 
> problem. I've attached the patch
> EDIT: updated the patch to cover checkAndPut(), checkAndDelete()
> UPDATE: updated the patch to use *byteBufferToByteArray()* instead of 
> *getBytes()* , also removed unused imports.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to