[
https://issues.apache.org/jira/browse/HBASE-8699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13702822#comment-13702822
]
Ted Yu commented on HBASE-8699:
-------------------------------
bq. What is this test doing? ... Remove it I'd say?
Fine with removing testExistenceOfIsFileClosed().
bq. We will do this reflection (and fail most of the time, at least currently)
whenever we make this call?
I will move getMethod() call to when isFileClosed() is about to be called.
> Parameter to DistributedFileSystem#isFileClosed should be of type Path
> ----------------------------------------------------------------------
>
> Key: HBASE-8699
> URL: https://issues.apache.org/jira/browse/HBASE-8699
> Project: HBase
> Issue Type: Bug
> Components: wal
> Reporter: Ted Yu
> Assignee: Ted Yu
> Attachments: 8699-v1.txt, 8699-v3.txt, 8699-v4.txt
>
>
> Here is current code of FSHDFSUtils#isFileClosed():
> {code}
> boolean isFileClosed(final DistributedFileSystem dfs, final Path p) {
> try {
> Method m = dfs.getClass().getMethod("isFileClosed", new Class<?>[]
> {String.class});
> return (Boolean) m.invoke(dfs, p.toString());
> {code}
> We look for isFileClosed method with parameter type of String.
> However, from
> hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DistributedFileSystem.java
> (branch-2):
> {code}
> public boolean isFileClosed(Path src) throws IOException {
> {code}
> The parameter type is of Path.
> This means we would get NoSuchMethodException.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
