[
https://issues.apache.org/jira/browse/HBASE-1502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13025520#comment-13025520
]
[email protected] commented on HBASE-1502:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/647/
-----------------------------------------------------------
(Updated 2011-04-26 23:50:23.656187)
Review request for hbase.
Changes
-------
All tests pass now. I'd like to get this patch in soon. I'm currently
spending a good bit of my time trying to keep this patch up with current TRUNK.
I'd rather commit and then address issues after.
This version of the patch does one make significant change though in that it
deprecates prewarmRegionCache. IMO this is a burdensome feature that is little
used; i'd like to have it die off.
Summary
-------
This patch does not completely remove heartbeats. It unburdens the heartbeat
of control messages; now heartbeat is used to
send the master load only (At most recent hackathon we had rough agreement that
we'd keep heartbeat to carry load)... if we miss some, no biggie.
RPC version changed on HMasterRegionInfo since the regionServerStartup and
regionServerReport arguments have changed.
We pass a String now instead of HServerAddress so this should help with our DNS
issues where the two sides disagree.
Removed HMsg.
HServerAddress as been sort_of_deprecated. Its in our API so can't remove it
easily (its embedded inside HRegionLocation).
Otherwise, we don't use it internally anymore.
HServerInfo is deprecated. Server meta data is now available in new class
ServerName and load lives apart from HSI now.
Fixed up regionserver and master startup so they now look the same.
New tests
Cruft cleanup.
This addresses bug hbase-1502.
https://issues.apache.org/jira/browse/hbase-1502
Diffs (updated)
-----
src/main/java/org/apache/hadoop/hbase/ClusterStatus.java 26a8bef
src/main/java/org/apache/hadoop/hbase/HConstants.java 5701639
src/main/java/org/apache/hadoop/hbase/HMsg.java 87beb00
src/main/java/org/apache/hadoop/hbase/HRegionLocation.java bd353b8
src/main/java/org/apache/hadoop/hbase/HServerAddress.java 7f8a472
src/main/java/org/apache/hadoop/hbase/HServerInfo.java 0b5bd94
src/main/java/org/apache/hadoop/hbase/HServerLoad.java 2372053
src/main/java/org/apache/hadoop/hbase/LocalHBaseCluster.java 0d696ab
src/main/java/org/apache/hadoop/hbase/MasterAddressTracker.java 1da9742
src/main/java/org/apache/hadoop/hbase/Server.java df396fa
src/main/java/org/apache/hadoop/hbase/ServerName.java PRE-CREATION
src/main/java/org/apache/hadoop/hbase/avro/AvroUtil.java d7a1e67
src/main/java/org/apache/hadoop/hbase/catalog/CatalogTracker.java be31179
src/main/java/org/apache/hadoop/hbase/catalog/MetaEditor.java c2ee031
src/main/java/org/apache/hadoop/hbase/catalog/MetaReader.java 6e22cf5
src/main/java/org/apache/hadoop/hbase/catalog/RootLocationEditor.java aee64c5
src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java afb666a
src/main/java/org/apache/hadoop/hbase/client/HConnection.java 2bb4725
src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java c348f7a
src/main/java/org/apache/hadoop/hbase/client/HTable.java edacf56
src/main/java/org/apache/hadoop/hbase/client/RetriesExhaustedWithDetailsException.java
6c62024
src/main/java/org/apache/hadoop/hbase/coprocessor/BaseMasterObserver.java
8df6aa4
src/main/java/org/apache/hadoop/hbase/coprocessor/MasterObserver.java d64817f
src/main/java/org/apache/hadoop/hbase/executor/EventHandler.java c22e342
src/main/java/org/apache/hadoop/hbase/executor/RegionTransitionData.java
a55f9d6
src/main/java/org/apache/hadoop/hbase/io/HbaseObjectWritable.java d8f8463
src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java ec28de4
src/main/java/org/apache/hadoop/hbase/ipc/HMasterRegionInterface.java 25139b3
src/main/java/org/apache/hadoop/hbase/ipc/HRegionInterface.java 663cab5
src/main/java/org/apache/hadoop/hbase/ipc/WritableRpcEngine.java 2273e55
src/main/java/org/apache/hadoop/hbase/master/ActiveMasterManager.java 66a3345
src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java 58fdb30
src/main/java/org/apache/hadoop/hbase/master/DeadServer.java 05600c4
src/main/java/org/apache/hadoop/hbase/master/HMaster.java 79a48ba
src/main/java/org/apache/hadoop/hbase/master/LoadBalancer.java 6c92cbc
src/main/java/org/apache/hadoop/hbase/master/MasterCoprocessorHost.java
4bb072e
src/main/java/org/apache/hadoop/hbase/master/MasterFileSystem.java 55e0162
src/main/java/org/apache/hadoop/hbase/master/ServerManager.java 04befe9
src/main/java/org/apache/hadoop/hbase/master/SplitLogManager.java dada818
src/main/java/org/apache/hadoop/hbase/master/handler/MetaServerShutdownHandler.java
eb01a6a
src/main/java/org/apache/hadoop/hbase/master/handler/OpenedRegionHandler.java
c478ab7
src/main/java/org/apache/hadoop/hbase/master/handler/ServerShutdownHandler.java
60662c2
src/main/java/org/apache/hadoop/hbase/master/handler/SplitRegionHandler.java
fee0b3d
src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java c065702
src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java d0a1e11
src/main/java/org/apache/hadoop/hbase/regionserver/RegionServerServices.java
6282b9e
src/main/java/org/apache/hadoop/hbase/regionserver/SplitLogWorker.java
fe807f3
src/main/java/org/apache/hadoop/hbase/regionserver/SplitTransaction.java
1b521f6
src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java 7569992
src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeer.java
548c8eb
src/main/java/org/apache/hadoop/hbase/replication/ReplicationZookeeper.java
f282c6d
src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java
78c3b42
src/main/java/org/apache/hadoop/hbase/rest/StorageClusterStatusResource.java
578ee14
src/main/java/org/apache/hadoop/hbase/util/Addressing.java PRE-CREATION
src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java 5da5e34
src/main/java/org/apache/hadoop/hbase/util/HBaseFsckRepair.java b624d28
src/main/java/org/apache/hadoop/hbase/util/JVMClusterUtil.java baf0c27
src/main/java/org/apache/hadoop/hbase/zookeeper/RegionServerTracker.java
0437484
src/main/java/org/apache/hadoop/hbase/zookeeper/RootRegionTracker.java
692b608
src/main/java/org/apache/hadoop/hbase/zookeeper/ZKAssign.java 34e17b6
src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java 7f5b377
src/main/resources/hbase-webapps/master/master.jsp eeabc0a
src/main/resources/hbase-webapps/master/table.jsp 6fcf16f
src/test/java/org/apache/hadoop/hbase/MiniHBaseCluster.java 28d2205
src/test/java/org/apache/hadoop/hbase/TestHRegionLocation.java PRE-CREATION
src/test/java/org/apache/hadoop/hbase/TestHServerAddress.java PRE-CREATION
src/test/java/org/apache/hadoop/hbase/TestHServerInfo.java PRE-CREATION
src/test/java/org/apache/hadoop/hbase/TestRegionRebalancing.java 11b94fe
src/test/java/org/apache/hadoop/hbase/TestSerialization.java 40874fc
src/test/java/org/apache/hadoop/hbase/TestServerName.java PRE-CREATION
src/test/java/org/apache/hadoop/hbase/catalog/TestCatalogTracker.java e25184e
src/test/java/org/apache/hadoop/hbase/catalog/TestCatalogTrackerOnCluster.java
66c6959
src/test/java/org/apache/hadoop/hbase/catalog/TestMetaReaderEditor.java
60320a3
src/test/java/org/apache/hadoop/hbase/coprocessor/TestMasterObserver.java
0829c8e
src/test/java/org/apache/hadoop/hbase/master/BROKE_FIX_TestKillingServersFromMaster.java
21b76fa
src/test/java/org/apache/hadoop/hbase/master/OOMEHMaster.java bf5ed03
src/test/java/org/apache/hadoop/hbase/master/TestActiveMasterManager.java
1a19941
src/test/java/org/apache/hadoop/hbase/master/TestCatalogJanitor.java 57d85d8
src/test/java/org/apache/hadoop/hbase/master/TestClockSkewDetection.java
915cdf6
src/test/java/org/apache/hadoop/hbase/master/TestDeadServer.java 61baf7d
src/test/java/org/apache/hadoop/hbase/master/TestDistributedLogSplitting.java
6f718f1
src/test/java/org/apache/hadoop/hbase/master/TestHMasterRPCException.java
a1bb6af
src/test/java/org/apache/hadoop/hbase/master/TestLoadBalancer.java 6b2dc53
src/test/java/org/apache/hadoop/hbase/master/TestLogsCleaner.java 19220fb
src/test/java/org/apache/hadoop/hbase/master/TestMaster.java c4ea83f
src/test/java/org/apache/hadoop/hbase/master/TestMasterFailover.java 5a334e0
src/test/java/org/apache/hadoop/hbase/master/TestRestartCluster.java dff6c1b
src/test/java/org/apache/hadoop/hbase/master/TestRollingRestart.java 6089ae6
src/test/java/org/apache/hadoop/hbase/regionserver/TestMasterAddressManager.java
319a74e
src/test/java/org/apache/hadoop/hbase/regionserver/TestScanner.java 7ff6a2e
src/test/java/org/apache/hadoop/hbase/regionserver/TestSplitLogWorker.java
9dd71a3
src/test/java/org/apache/hadoop/hbase/regionserver/TestSplitTransactionOnCluster.java
7fc44e9
src/test/java/org/apache/hadoop/hbase/regionserver/handler/TestOpenRegionHandler.java
bc0a327
src/test/java/org/apache/hadoop/hbase/replication/regionserver/TestReplicationSourceManager.java
20a1ff8
src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java a055082
Diff: https://reviews.apache.org/r/647/diff
Testing
-------
Most tests pass. I have yet to run it on a cluster. Doing that now.
Thanks,
Michael
> Remove need for heartbeats in HBase
> -----------------------------------
>
> Key: HBASE-1502
> URL: https://issues.apache.org/jira/browse/HBASE-1502
> Project: HBase
> Issue Type: Task
> Reporter: Nitay Joffe
> Assignee: stack
> Priority: Blocker
> Fix For: 0.92.0
>
> Attachments: 1502-4.txt, 1502-v2.txt, 1502-v5.txt, 1502-v6.txt,
> 1502-v7.txt, 1502.txt
>
>
> HBase currently uses heartbeats between region servers and the master,
> piggybacking information on them when it can. This issue is to investigate if
> we can get rid of the need for those using ZooKeeper events.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
