[
https://issues.apache.org/jira/browse/HBASE-1502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13025915#comment-13025915
]
[email protected] commented on HBASE-1502:
------------------------------------------------------
bq. On 2011-04-27 00:17:30, Jonathan Gray wrote:
bq. > src/main/java/org/apache/hadoop/hbase/ClusterStatus.java, line 113
bq. > <https://reviews.apache.org/r/647/diff/4/?file=17400#file17400line113>
bq. >
bq. > Can just use this.liveServers.values() for here and below?
value is HServerLoad (Not a List of HRegionInfo). We want count of regions.
I did remove the dup iteration having getAverageLoad instead call
getRegionsCount.
bq. On 2011-04-27 00:17:30, Jonathan Gray wrote:
bq. > src/main/java/org/apache/hadoop/hbase/HServerInfo.java, line 42
bq. > <https://reviews.apache.org/r/647/diff/4/?file=17405#file17405line42>
bq. >
bq. > i see webuiport below, does this TODO still apply?
It does.
HSI is deprecated and after this patch goes in, there is no means of the RS
telling Master of its webui port -- in master we'll rely on configs. In rare
case where webui port changes -- it can if occupied -- then master will be off.
Will address elsewhere. Will write json to the RS ephemeral node with
'metadata' about the RS that will include webui port but likely other stuff
that could be factored doing loading calculations, etc. (it used to hold a HSA
but thats been bumped in this patch). Will file an issue after this patch goes
in.
bq. On 2011-04-27 00:17:30, Jonathan Gray wrote:
bq. > src/main/java/org/apache/hadoop/hbase/MasterAddressTracker.java, line 83
bq. > <https://reviews.apache.org/r/647/diff/4/?file=17408#file17408line83>
bq. >
bq. > why String and not ServerName? because master has no startcode? (i
see use of ServerName for master above tho)
I changed it (This method is not used anywhere seemingly).
bq. On 2011-04-27 00:17:30, Jonathan Gray wrote:
bq. > src/main/java/org/apache/hadoop/hbase/HServerAddress.java, line 42
bq. > <https://reviews.apache.org/r/647/diff/4/?file=17404#file17404line42>
bq. >
bq. > Where is this actually used now? Should point it out here so it's
clear and so that when it goes away we know we can get rid of this.
Will do. Had a change of heart last night; previous was going to just
'sort-of' deprecate HSA but on way home, after thinking on it, HSA is just
never a good idea so will outright deprecate it.
bq. On 2011-04-27 00:17:30, Jonathan Gray wrote:
bq. > src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java, line 792
bq. > <https://reviews.apache.org/r/647/diff/4/?file=17416#file17416line792>
bq. >
bq. > this is because HSA actually makes a connection or does the lookup?
This I'll purge. I'll use the getConnection(ISA) that this patch adds instead
so no reference to HSA in HBaseAdmin (except deprecated uses)
- Michael
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/647/#review568
-----------------------------------------------------------
On 2011-04-26 23:50:23, Michael Stack wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/647/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-04-26 23:50:23)
bq.
bq.
bq. Review request for hbase.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. This patch does not completely remove heartbeats. It unburdens the
heartbeat of control messages; now heartbeat is used to
bq. send the master load only (At most recent hackathon we had rough agreement
that we'd keep heartbeat to carry load)... if we miss some, no biggie.
bq.
bq. RPC version changed on HMasterRegionInfo since the regionServerStartup and
regionServerReport arguments have changed.
bq. We pass a String now instead of HServerAddress so this should help with
our DNS issues where the two sides disagree.
bq.
bq. Removed HMsg.
bq.
bq. HServerAddress as been sort_of_deprecated. Its in our API so can't remove
it easily (its embedded inside HRegionLocation).
bq. Otherwise, we don't use it internally anymore.
bq.
bq. HServerInfo is deprecated. Server meta data is now available in new class
ServerName and load lives apart from HSI now.
bq.
bq. Fixed up regionserver and master startup so they now look the same.
bq.
bq. New tests
bq.
bq. Cruft cleanup.
bq.
bq.
bq. This addresses bug hbase-1502.
bq. https://issues.apache.org/jira/browse/hbase-1502
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/main/java/org/apache/hadoop/hbase/ClusterStatus.java 26a8bef
bq. src/main/java/org/apache/hadoop/hbase/HConstants.java 5701639
bq. src/main/java/org/apache/hadoop/hbase/HMsg.java 87beb00
bq. src/main/java/org/apache/hadoop/hbase/HRegionLocation.java bd353b8
bq. src/main/java/org/apache/hadoop/hbase/HServerAddress.java 7f8a472
bq. src/main/java/org/apache/hadoop/hbase/HServerInfo.java 0b5bd94
bq. src/main/java/org/apache/hadoop/hbase/HServerLoad.java 2372053
bq. src/main/java/org/apache/hadoop/hbase/LocalHBaseCluster.java 0d696ab
bq. src/main/java/org/apache/hadoop/hbase/MasterAddressTracker.java 1da9742
bq. src/main/java/org/apache/hadoop/hbase/Server.java df396fa
bq. src/main/java/org/apache/hadoop/hbase/ServerName.java PRE-CREATION
bq. src/main/java/org/apache/hadoop/hbase/avro/AvroUtil.java d7a1e67
bq. src/main/java/org/apache/hadoop/hbase/catalog/CatalogTracker.java
be31179
bq. src/main/java/org/apache/hadoop/hbase/catalog/MetaEditor.java c2ee031
bq. src/main/java/org/apache/hadoop/hbase/catalog/MetaReader.java 6e22cf5
bq. src/main/java/org/apache/hadoop/hbase/catalog/RootLocationEditor.java
aee64c5
bq. src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java afb666a
bq. src/main/java/org/apache/hadoop/hbase/client/HConnection.java 2bb4725
bq. src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
c348f7a
bq. src/main/java/org/apache/hadoop/hbase/client/HTable.java edacf56
bq.
src/main/java/org/apache/hadoop/hbase/client/RetriesExhaustedWithDetailsException.java
6c62024
bq.
src/main/java/org/apache/hadoop/hbase/coprocessor/BaseMasterObserver.java
8df6aa4
bq. src/main/java/org/apache/hadoop/hbase/coprocessor/MasterObserver.java
d64817f
bq. src/main/java/org/apache/hadoop/hbase/executor/EventHandler.java c22e342
bq. src/main/java/org/apache/hadoop/hbase/executor/RegionTransitionData.java
a55f9d6
bq. src/main/java/org/apache/hadoop/hbase/io/HbaseObjectWritable.java
d8f8463
bq. src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java ec28de4
bq. src/main/java/org/apache/hadoop/hbase/ipc/HMasterRegionInterface.java
25139b3
bq. src/main/java/org/apache/hadoop/hbase/ipc/HRegionInterface.java 663cab5
bq. src/main/java/org/apache/hadoop/hbase/ipc/WritableRpcEngine.java 2273e55
bq. src/main/java/org/apache/hadoop/hbase/master/ActiveMasterManager.java
66a3345
bq. src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
58fdb30
bq. src/main/java/org/apache/hadoop/hbase/master/DeadServer.java 05600c4
bq. src/main/java/org/apache/hadoop/hbase/master/HMaster.java 79a48ba
bq. src/main/java/org/apache/hadoop/hbase/master/LoadBalancer.java 6c92cbc
bq. src/main/java/org/apache/hadoop/hbase/master/MasterCoprocessorHost.java
4bb072e
bq. src/main/java/org/apache/hadoop/hbase/master/MasterFileSystem.java
55e0162
bq. src/main/java/org/apache/hadoop/hbase/master/ServerManager.java 04befe9
bq. src/main/java/org/apache/hadoop/hbase/master/SplitLogManager.java
dada818
bq.
src/main/java/org/apache/hadoop/hbase/master/handler/MetaServerShutdownHandler.java
eb01a6a
bq.
src/main/java/org/apache/hadoop/hbase/master/handler/OpenedRegionHandler.java
c478ab7
bq.
src/main/java/org/apache/hadoop/hbase/master/handler/ServerShutdownHandler.java
60662c2
bq.
src/main/java/org/apache/hadoop/hbase/master/handler/SplitRegionHandler.java
fee0b3d
bq. src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java c065702
bq. src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
d0a1e11
bq.
src/main/java/org/apache/hadoop/hbase/regionserver/RegionServerServices.java
6282b9e
bq. src/main/java/org/apache/hadoop/hbase/regionserver/SplitLogWorker.java
fe807f3
bq. src/main/java/org/apache/hadoop/hbase/regionserver/SplitTransaction.java
1b521f6
bq. src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java 7569992
bq. src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeer.java
548c8eb
bq.
src/main/java/org/apache/hadoop/hbase/replication/ReplicationZookeeper.java
f282c6d
bq.
src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java
78c3b42
bq.
src/main/java/org/apache/hadoop/hbase/rest/StorageClusterStatusResource.java
578ee14
bq. src/main/java/org/apache/hadoop/hbase/util/Addressing.java PRE-CREATION
bq. src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java 5da5e34
bq. src/main/java/org/apache/hadoop/hbase/util/HBaseFsckRepair.java b624d28
bq. src/main/java/org/apache/hadoop/hbase/util/JVMClusterUtil.java baf0c27
bq. src/main/java/org/apache/hadoop/hbase/zookeeper/RegionServerTracker.java
0437484
bq. src/main/java/org/apache/hadoop/hbase/zookeeper/RootRegionTracker.java
692b608
bq. src/main/java/org/apache/hadoop/hbase/zookeeper/ZKAssign.java 34e17b6
bq. src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java 7f5b377
bq. src/main/resources/hbase-webapps/master/master.jsp eeabc0a
bq. src/main/resources/hbase-webapps/master/table.jsp 6fcf16f
bq. src/test/java/org/apache/hadoop/hbase/MiniHBaseCluster.java 28d2205
bq. src/test/java/org/apache/hadoop/hbase/TestHRegionLocation.java
PRE-CREATION
bq. src/test/java/org/apache/hadoop/hbase/TestHServerAddress.java
PRE-CREATION
bq. src/test/java/org/apache/hadoop/hbase/TestHServerInfo.java PRE-CREATION
bq. src/test/java/org/apache/hadoop/hbase/TestRegionRebalancing.java 11b94fe
bq. src/test/java/org/apache/hadoop/hbase/TestSerialization.java 40874fc
bq. src/test/java/org/apache/hadoop/hbase/TestServerName.java PRE-CREATION
bq. src/test/java/org/apache/hadoop/hbase/catalog/TestCatalogTracker.java
e25184e
bq.
src/test/java/org/apache/hadoop/hbase/catalog/TestCatalogTrackerOnCluster.java
66c6959
bq. src/test/java/org/apache/hadoop/hbase/catalog/TestMetaReaderEditor.java
60320a3
bq.
src/test/java/org/apache/hadoop/hbase/coprocessor/TestMasterObserver.java
0829c8e
bq.
src/test/java/org/apache/hadoop/hbase/master/BROKE_FIX_TestKillingServersFromMaster.java
21b76fa
bq. src/test/java/org/apache/hadoop/hbase/master/OOMEHMaster.java bf5ed03
bq.
src/test/java/org/apache/hadoop/hbase/master/TestActiveMasterManager.java
1a19941
bq. src/test/java/org/apache/hadoop/hbase/master/TestCatalogJanitor.java
57d85d8
bq. src/test/java/org/apache/hadoop/hbase/master/TestClockSkewDetection.java
915cdf6
bq. src/test/java/org/apache/hadoop/hbase/master/TestDeadServer.java 61baf7d
bq.
src/test/java/org/apache/hadoop/hbase/master/TestDistributedLogSplitting.java
6f718f1
bq.
src/test/java/org/apache/hadoop/hbase/master/TestHMasterRPCException.java
a1bb6af
bq. src/test/java/org/apache/hadoop/hbase/master/TestLoadBalancer.java
6b2dc53
bq. src/test/java/org/apache/hadoop/hbase/master/TestLogsCleaner.java
19220fb
bq. src/test/java/org/apache/hadoop/hbase/master/TestMaster.java c4ea83f
bq. src/test/java/org/apache/hadoop/hbase/master/TestMasterFailover.java
5a334e0
bq. src/test/java/org/apache/hadoop/hbase/master/TestRestartCluster.java
dff6c1b
bq. src/test/java/org/apache/hadoop/hbase/master/TestRollingRestart.java
6089ae6
bq.
src/test/java/org/apache/hadoop/hbase/regionserver/TestMasterAddressManager.java
319a74e
bq. src/test/java/org/apache/hadoop/hbase/regionserver/TestScanner.java
7ff6a2e
bq.
src/test/java/org/apache/hadoop/hbase/regionserver/TestSplitLogWorker.java
9dd71a3
bq.
src/test/java/org/apache/hadoop/hbase/regionserver/TestSplitTransactionOnCluster.java
7fc44e9
bq.
src/test/java/org/apache/hadoop/hbase/regionserver/handler/TestOpenRegionHandler.java
bc0a327
bq.
src/test/java/org/apache/hadoop/hbase/replication/regionserver/TestReplicationSourceManager.java
20a1ff8
bq. src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java a055082
bq.
bq. Diff: https://reviews.apache.org/r/647/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Most tests pass. I have yet to run it on a cluster. Doing that now.
bq.
bq.
bq. Thanks,
bq.
bq. Michael
bq.
bq.
> Remove need for heartbeats in HBase
> -----------------------------------
>
> Key: HBASE-1502
> URL: https://issues.apache.org/jira/browse/HBASE-1502
> Project: HBase
> Issue Type: Task
> Reporter: Nitay Joffe
> Assignee: stack
> Priority: Blocker
> Fix For: 0.92.0
>
> Attachments: 1502-4.txt, 1502-v2.txt, 1502-v5.txt, 1502-v6.txt,
> 1502-v7.txt, 1502.txt
>
>
> HBase currently uses heartbeats between region servers and the master,
> piggybacking information on them when it can. This issue is to investigate if
> we can get rid of the need for those using ZooKeeper events.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
