[
https://issues.apache.org/jira/browse/HBASE-8329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13704020#comment-13704020
]
Jean-Daniel Cryans commented on HBASE-8329:
-------------------------------------------
bq. Info level seems reasonable for this message, given the experimental nature
of the feature; it is only logged if throttling happened.
We should improve it then. {{maxSpeedInPeak}} doesn't seem to change, not sure
why you'd print it every time. {{sleepNumber}} doesn't mean much, the only
sleep number I know is this one http://www.sleepnumber.com/, maybe
{{numberOfSleeps}} or {{sleepCounter}} or {{numberOfThrottles}} would be better?
bq. Peak hours naming follows the existing convention for off-peak hours that
was there for quite a while.
There is a lot of confusion in the code right now between peak and off-peak
hours. I would also question the "convention" since it's not respecting what we
usually do, as exposed by this patch.
bq. The rest (renames/comments) - do you want to revert, or to have an addendum?
Addendum should be fine, shouldn't take too long to fix IMO.
Also it looks like the test fails in 2 out of 3 runs (see previous build
comments).
> Limit compaction speed
> ----------------------
>
> Key: HBASE-8329
> URL: https://issues.apache.org/jira/browse/HBASE-8329
> Project: HBase
> Issue Type: Improvement
> Components: Compaction
> Reporter: binlijin
> Assignee: binlijin
> Fix For: 0.95.2
>
> Attachments: HBASE-8329-2-trunk.patch, HBASE-8329-3-trunk.patch,
> HBASE-8329-4-trunk.patch, HBASE-8329-5-trunk.patch, HBASE-8329-trunk.patch
>
>
> There is no speed or resource limit for compaction，I think we should add this
> feature especially when request burst.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
