[
https://issues.apache.org/jira/browse/HBASE-8329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13712791#comment-13712791
]
Jean-Daniel Cryans commented on HBASE-8329:
-------------------------------------------
On the latest patch:
Do s/two/too, and I would like to see more documentation here, mostly regarding
how to use the different configurations:
{noformat}
+/**
+ * Limit peak hour compaction speed , slow down when it is two fast.
+ */
{noformat}
Here we have the same problem as before. I'm reading "if is not off peak hour?"
but IIUC what it means "if is not peak hour"? If you want to use OffPeakHours
to describe PeakHours, please refactor OffPeakHours to have a more abstract
meaning:
{noformat}
+ if (!offPeakHours.isOffPeakHour()) {
+ // not peak hour, just return.
+ return;
+ }
{noformat}
Finally, offPeakHours (or whatever it becomes), maxSpeedInPeak and
checkInterval should be declared final.
> Limit compaction speed
> ----------------------
>
> Key: HBASE-8329
> URL: https://issues.apache.org/jira/browse/HBASE-8329
> Project: HBase
> Issue Type: Improvement
> Components: Compaction
> Reporter: binlijin
> Assignee: binlijin
> Fix For: 0.95.2
>
> Attachments: HBASE-8329-2-trunk.patch, HBASE-8329-3-trunk.patch,
> HBASE-8329-4-trunk.patch, HBASE-8329-5-trunk.patch, HBASE-8329-6-trunk.patch,
> HBASE-8329-trunk.patch
>
>
> There is no speed or resource limit for compaction，I think we should add this
> feature especially when request burst.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
