[
https://issues.apache.org/jira/browse/HBASE-8911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13704743#comment-13704743
]
Elliott Clark commented on HBASE-8911:
--------------------------------------
{code}
+ Span logSplitSpan = Trace.startSpan(getClass().getSimpleName(),
Sampler.ALWAYS);
{code}
Always tracing every log splitting seems like it's unnecessary. Should we make
internal tracing configurable so that a bunch of spans and traces aren't
created if there's no SpanReceiver registered ?
{code}
+ if (logSplitSpan != null) logSplitSpan.stop();
{code}
Can this be left around if there's an error thrown ?
{code}
+ Span amSpan = Trace.startSpan(getClass().getSimpleName() + " -
Assignment Manager",
+ Sampler.ALWAYS);
{code}
This feels like it should be in assignment manager rather than in the class
using assignment manager.
{code}
+ // htracing stuff.
+ spanReceiverHost = new SpanReceiverHost(getConfiguration());
+ spanReceiverHost.loadSpanReceivers();
{code}
Better comment please. A lot more comments would be really helpful.
These traces all
> Inject MTTR specific traces to get a break up of various steps
> --------------------------------------------------------------
>
> Key: HBASE-8911
> URL: https://issues.apache.org/jira/browse/HBASE-8911
> Project: HBase
> Issue Type: Bug
> Components: MTTR
> Affects Versions: 0.95.1
> Reporter: Himanshu Vashishtha
> Attachments: 8911-v0.patch
>
>
> There are various steps involved in a regionserver recovery process. This
> jira adds instrumentation at various places in order to get an idea what are
> the steps involved in a regionserver recovery and how much time is spent in
> each of these parts.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
