[
https://issues.apache.org/jira/browse/HBASE-8911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13704762#comment-13704762
]
Himanshu Vashishtha commented on HBASE-8911:
--------------------------------------------
Thanks for the reviews.
bq. Should we make internal tracing configurable so that a bunch of spans and
traces aren't created if there's no SpanReceiver registered ?
Yes, that could be done in the htrace library itself.
bq. Can this be left around if there's an error thrown ?
If that happens, that would be a bug in the htrace library. Let me take a look.
bq. This feels like it should be in assignment manager rather than in the class
using assignment manager.
Yeah, I agree. But the reason I tied it in the SSH is because I was interested
in the call made from SSH (mttr specific use case); the method to assign
regions is invoked from other places too, and that would have interfered with
the mttr traces. Let me know if you think otherwise.
Okay, I will add more comments :)
> Inject MTTR specific traces to get a break up of various steps
> --------------------------------------------------------------
>
> Key: HBASE-8911
> URL: https://issues.apache.org/jira/browse/HBASE-8911
> Project: HBase
> Issue Type: Bug
> Components: MTTR
> Affects Versions: 0.95.1
> Reporter: Himanshu Vashishtha
> Attachments: 8911-v0.patch
>
>
> There are various steps involved in a regionserver recovery process. This
> jira adds instrumentation at various places in order to get an idea what are
> the steps involved in a regionserver recovery and how much time is spent in
> each of these parts.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
