[ 
https://issues.apache.org/jira/browse/HBASE-8938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13707047#comment-13707047
 ] 

Hamed Madani commented on HBASE-8938:
-------------------------------------

>From what I understand , removing the scanner reference from internal map wont 
>close the scanner instance itself. Maybe I'm wrong , but I thought 
>scanner.close() has to be called to free resources. Looking at thrift 1 
>closeScanner function , scanner.close() gets called before removing the 
>scannerId from internal map.
                
> Thrift2 does not close scanner instance
> ---------------------------------------
>
>                 Key: HBASE-8938
>                 URL: https://issues.apache.org/jira/browse/HBASE-8938
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Thrift
>    Affects Versions: 0.94.0
>            Reporter: Hamed Madani
>              Labels: thrift2
>         Attachments: HBASE-8938-0.94.patch, HBASE-8938.patch
>
>
> closeScanner at *ThriftHBaseServiceHandler* simply remove scannerId from 
> internal map, but fails to close the scanner instance. 
> {code}
>   public void closeScanner(int scannerId) throws TIOError, TIllegalArgument, 
> TException {
>     if (removeScanner(scannerId) == null) {
>       TIllegalArgument ex = new TIllegalArgument();
>       ex.setMessage("Invalid scanner Id");
>       throw ex;
>     }
>   }
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to