[ 
https://issues.apache.org/jira/browse/HBASE-8938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13707697#comment-13707697
 ] 

Hadoop QA commented on HBASE-8938:
----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12592002/HBASE-8938-0.94.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    {color:red}-1 patch{color}.  The patch command could not apply the patch.

Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/6323//console

This message is automatically generated.
                
> Thrift2 does not close scanner instance
> ---------------------------------------
>
>                 Key: HBASE-8938
>                 URL: https://issues.apache.org/jira/browse/HBASE-8938
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Thrift
>    Affects Versions: 0.94.0
>            Reporter: Hamed Madani
>              Labels: thrift2
>         Attachments: HBASE-8938-0.94.patch, HBASE-8938.patch
>
>
> closeScanner at *ThriftHBaseServiceHandler* simply remove scannerId from 
> internal map, but fails to close the scanner instance. 
> {code}
>   public void closeScanner(int scannerId) throws TIOError, TIllegalArgument, 
> TException {
>     if (removeScanner(scannerId) == null) {
>       TIllegalArgument ex = new TIllegalArgument();
>       ex.setMessage("Invalid scanner Id");
>       throw ex;
>     }
>   }
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to