[ 
https://issues.apache.org/jira/browse/HBASE-8642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13715694#comment-13715694
 ] 

Matteo Bertozzi commented on HBASE-8642:
----------------------------------------

patch looks good to me, now doesn't apply cleanly but the fix is trivial.
my main concern with this feature is related to the rename semantic, where you 
rename a table and listing/deleting with the old rename results in including 
the snapshots made on before the rename table. Which may be fine, since may be 
considered not totally wrong and we don't have rename support in the core.

so, I'm +1 on the code and +0 on the merge, I'll let you decide.
                
> [Snapshot] List and delete snapshot by table
> --------------------------------------------
>
>                 Key: HBASE-8642
>                 URL: https://issues.apache.org/jira/browse/HBASE-8642
>             Project: HBase
>          Issue Type: Improvement
>          Components: snapshots
>    Affects Versions: 0.98.0, 0.95.0, 0.95.1, 0.95.2
>            Reporter: Julian Zhou
>            Assignee: Julian Zhou
>            Priority: Minor
>             Fix For: 0.98.0, 0.95.0, 0.95.2
>
>         Attachments: 8642-trunk-0.95-v0.patch, 8642-trunk-0.95-v1.patch, 
> 8642-trunk-0.95-v2.patch
>
>
> Support list and delete snapshot by table name.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to