[
https://issues.apache.org/jira/browse/HBASE-8496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13721752#comment-13721752
]
Ted Yu commented on HBASE-8496:
-------------------------------
In PrefixTreeBlockMeta.java, there is method setTagValueBytes().
Is it used anywhere ?
In PrefixTreeCodec.java :
{code}
+ //TODO : Should i pass true here for includeTags
+ searcher = DecoderFactory.checkOut(block, true, true);
{code}
Passing includesTag parameter to checkOut() method ?
In TestRowData.java, I saw:
{code}
- all.add(new TestRowDataSimple());
+ /*all.add(new TestRowDataSimple());
all.add(new TestRowDataDeeper());
{code}
Did you encounter some issue that prevented the test to pass ?
In PrefixTree tests, false is passed for includesTag:
{code}
- encoder = new PrefixTreeEncoder(os, includeMemstoreTS);
+ encoder = new PrefixTreeEncoder(os, includeMemstoreTS, false);
{code}
Do you want to add tag tests for PrefixTree in another issue ?
> Implement tags and the internals of how a tag should look like
> --------------------------------------------------------------
>
> Key: HBASE-8496
> URL: https://issues.apache.org/jira/browse/HBASE-8496
> Project: HBase
> Issue Type: New Feature
> Affects Versions: 0.98.0, 0.95.2
> Reporter: ramkrishna.s.vasudevan
> Assignee: ramkrishna.s.vasudevan
> Attachments: Comparison.pdf, HBASE-8496_2.patch, HBASE-8496.patch,
> Tag design.pdf, Tag_In_KV_Buffer_For_reference.patch
>
>
> The intent of this JIRA comes from HBASE-7897.
> This would help us to decide on the structure and format of how the tags
> should look like.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
