[ 
https://issues.apache.org/jira/browse/HBASE-9093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13724952#comment-13724952
 ] 

Hari Shreedharan commented on HBASE-9093:
-----------------------------------------

[~lhofhansl] - Thanks for your feedback. I am not against 
removing/upgrading/updating APIs. The only thing I am requesting is to 
deprecate the old API and keep them around long enough for downstream 
projects/users to upgrade to the versions of HBase where these APIs are 
removed. 

In this case, if setWriteToWal method was deprecated in 0.94 and then removed 
in 0.96, we would have made every effort to make sure we use the new 
setDurability API by the time HBase 0.96 is released (hopefully by then, most 
users would be using at least 0.94 where both APIs would have been available). 

>From the javadoc, it does not look like hbase 0.94 supported the setDurability 
>API though. 
>(http://hbase.apache.org/0.94/apidocs/org/apache/hadoop/hbase/client/Put.html 
>- is there a newer one?)


                
> Hbase client API: Restore the writeToWal method
> -----------------------------------------------
>
>                 Key: HBASE-9093
>                 URL: https://issues.apache.org/jira/browse/HBASE-9093
>             Project: HBase
>          Issue Type: Bug
>          Components: Client, Usability
>    Affects Versions: 0.95.0
>            Reporter: Hari Shreedharan
>             Fix For: 0.98.0, 0.95.2
>
>         Attachments: HBASE-9093.patch, HBASE-9093.patch, HBASE-9093.patch
>
>
> The writeToWal is used by downstream projects like Flume to disable writes to 
> WAL to improve performance when durability is not strictly required. But 
> renaming this method to setDurability forces us to use reflection to support 
> hbase versions < 95 - which in turn hits performance, as this method needs to 
> be called on every single write. I recommend adding the old method back as 
> deprecated and removing it once hbase-95/96 becomes the popular version used 
> in prod.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to