[
https://issues.apache.org/jira/browse/HBASE-8408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13727486#comment-13727486
]
Francis Liu commented on HBASE-8408:
------------------------------------
{quote}
+ hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java
Good you upped the fs version number.
I wonder if the tablename defines don't better belong in the new TableName
class.
{quote}
Yeah there's some table utilities (isSystem()) and constants.
{quote}
On the name of the datadir being .data, is that right? Did we talk about
changing the names of dirs after ns goes in to remove the '.' ? Would that be
after
this patch?
{quote}
We talked about it going in a separate patch. After reading Enis' reviews. I
decided to go with .data we can deal with all these directories in a separate
patch. Since you'll need downtime moving the others as well anyway?
{quote}
+ hbase-common/src/main/java/org/apache/hadoop/hbase/KeyValue.java
So the system ns is called 'hbase' and not 'system'?
HConstants.META_TABLE_NAME.getName().length; // 'hbase.meta' length
{quote}
Yeah this is an artifact of the '.' delimiter. Less chance someone has a table
named hbase.foo as opposed to system.foo. We can rename it back to system if
you'd like. Tho mysql has theirs named as mysql. Not sure about the others so
hbase should be fine too.
{quote}
+ hbase-common/src/main/java/org/apache/hadoop/hbase/TableName.java
I suppose it is ok haveing NS and TN in hbase-common. They have no dependency
on anything else.
What is a qualifier name in TN? A ns? Or it looks like it is the old
tablename? Should say
in javadoc since can confuse
TN#valueOf(byte []) and TN#valueOf(String) duplicate code.
Yeah, add some javadoc on what qualifier is. An example? Yeah, javadoc needs
examples.
Fix javadoc (missing @param)
{quote}
yeah qualifier is the old/simple table name. like column qualifier is to a
column. will fix doc.
{quote}
Looking at this script, can it resume if it fails midway through a migration
and it then
gets restarted again? It does not look like it.
{quote}
It essentially just goes through what hasn't been moved yet. And moves those.
There's nothing much else to do.
{quote}
Does it change the fs file version? I don't see it.
{quote}
Good catch will put that in.
{quote}
You have unit test for your new hfilelink regex?
{quote}
When I was looking for hfilelink tests I noticed most of the coverage is done
by snapshot tests so I just relied on that plus some new tests that's in
TestNamespaceUpgrade which tests non-default tables. That should cover the two
cases. Thinking about it I should move these tests into a snapshot test class
as well.
{quote}
You have a note about ':' being illegal but it is floating in the middle of the
file
unattached.
{quote}
line number?
> Implement namespace
> -------------------
>
> Key: HBASE-8408
> URL: https://issues.apache.org/jira/browse/HBASE-8408
> Project: HBase
> Issue Type: Sub-task
> Reporter: Francis Liu
> Assignee: Francis Liu
> Attachments: HBASE-8015_11.patch, HBASE-8015_12.patch,
> HBASE-8015_1.patch, HBASE-8015_2.patch, HBASE-8015_3.patch,
> HBASE-8015_4.patch, HBASE-8015_5.patch, HBASE-8015_6.patch,
> HBASE-8015_7.patch, HBASE-8015_8.patch, HBASE-8015_9.patch, HBASE-8015.patch,
> TestNamespaceMigration.tgz, TestNamespaceUpgrade.tgz
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
