[
https://issues.apache.org/jira/browse/HBASE-8408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13728270#comment-13728270
]
Ted Yu commented on HBASE-8408:
-------------------------------
Paging through review board was somehow very slow.
{code}
+ for(Iterator<HRegionInfo> iter = allRegions.keySet().iterator();
+ iter.hasNext();) {
+ if (HTableDescriptor.isSystemTable(iter.next().getTableName())) {
+ iter.remove();
+ }
+ }
{code}
I see 3 places in the patch where the above construct is used. It would be nice
to extract into a util method.
In TableNamespaceManager:
{code}
+ zkNamespaceManager.update(ns);
+ }
+ scanner.close();
{code}
Can you place the close() call in finally block ?
In upsert(NamespaceDescriptor ns), IOException from table.put(p) is not
considered fatal ?
Should we disallow splitting Namespace table ?
> Implement namespace
> -------------------
>
> Key: HBASE-8408
> URL: https://issues.apache.org/jira/browse/HBASE-8408
> Project: HBase
> Issue Type: Sub-task
> Reporter: Francis Liu
> Assignee: Francis Liu
> Attachments: HBASE-8015_11.patch, HBASE-8015_12.patch,
> HBASE-8015_1.patch, HBASE-8015_2.patch, HBASE-8015_3.patch,
> HBASE-8015_4.patch, HBASE-8015_5.patch, HBASE-8015_6.patch,
> HBASE-8015_7.patch, HBASE-8015_8.patch, HBASE-8015_9.patch, HBASE-8015.patch,
> TestNamespaceMigration.tgz, TestNamespaceUpgrade.tgz
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
