[ 
https://issues.apache.org/jira/browse/HBASE-8348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13744602#comment-13744602
 ] 

Jeffrey Zhong commented on HBASE-8348:
--------------------------------------

This tool is great! Today I populated some data with snapshots in a 0.94 
cluster and upgrade it to 0.96. After upgrade, all existing data are intact! 
When I looked at the code, there are some very minor things as following: 

1) it seems the following two lines in ZKDataMigrator.java are not needed:
{code}
      FileSystem fs = FileSystem.get(getConf());
      FSUtils.setFsDefault(conf, new Path(fs.getUri()));
{code}
2) If I specify both -ns -zk in command line, only name space is upgraded. 
3) Since ./bin/hbase run with default "INFO,console", in my option, we could 
use log4j to print message out instead of System.err.println. Because it prints 
out "Region server(s) ### are alive or  rs znodes not expired.", not sure it's 
an info, warn or error message.
                
> Polish the migration to 0.96
> ----------------------------
>
>                 Key: HBASE-8348
>                 URL: https://issues.apache.org/jira/browse/HBASE-8348
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.95.0
>            Reporter: Jean-Daniel Cryans
>            Assignee: rajeshbabu
>            Priority: Critical
>             Fix For: 0.96.0
>
>         Attachments: HBASE-8348-approach-2.patch, 
> HBASE-8348-approach-3.patch, HBASE-8348_trunk.patch, 
> HBASE-8348_trunk_v2.patch, HBASE-8348_trunk_v3.patch
>
>
> Currently, migration works but there's still a couple of rough edges:
>  - HBASE-8045 finished the .META. migration but didn't remove ROOT, so it's 
> still on the filesystem.
>  - Data in ZK needs to be removed manually. Either we fix up the data in ZK 
> or we delete it ourselves.
>  - TestMetaMigrationRemovingHTD has a testMetaUpdatedFlagInROOT method, but 
> ROOT is gone now.
> Elliott was also mentioning that we could have "hbase migrate" do the HFileV1 
> checks, clear ZK, remove ROOT, etc.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to