[
https://issues.apache.org/jira/browse/HBASE-8348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13747179#comment-13747179
]
Himanshu Vashishtha commented on HBASE-8348:
--------------------------------------------
Thanks for the reviews, Stack.
bq. ... what would a corrupt file be? Are you going to freak folks out if they
see this message? Does the v1 checker print out the instnaces of v1 hfiles?
A corrupt file is a store file which has an unknown major version (neither 1
nor 2). Yes, the tool prints out all such files, and also prints V1 files. I
will add in the description what does corrupt mean. I think it is important to
let the user know if there is any such file.
{code}
There are some HFileV1, or corrupt files (files with incorrect major version).
Please look at the log for a list of such files.
{code}
Sure, I have a patch to replace all system.out.xxx (in UploadTo96 and
HFileV1Detector tool) to LOG.xxx.
bq. Shoudl you proceed if the first has a non-zero result?
Namespace upgrade tool returns 0 unless there is any error (which it throws on
the caller). So, this would work too. But let me add the check.
bq. And why not just do return upgradeZNodes instead of catch result in a res
and the in new statement doing the return res.
Will do.
bq. Can't you get options to print this out for you anyways?
It is used, after the description on the tool. Okay, will make the help
consistent with other tools, by just printing the options. More description can
be added in the ref guide.
I think we should get this working patch in, and then do refinements based on
users feedback (before 0.96 comes out). I will upload a patch tonight, with a
log of its run.
BTW, I figured out that HBASE-9126 removed the V1 support altogether and now,
we get an exception if the major version is 1. Could that cleanup be done in
0.98 (or another dot release, in case we tell users to go through 0.96.0 before
doing any upgrade from 0.94.x). It is just a suggestion, though. I am okay
otherwise, and will fix the HFileV1 tool. Please let me know. Thanks.
> Polish the migration to 0.96
> ----------------------------
>
> Key: HBASE-8348
> URL: https://issues.apache.org/jira/browse/HBASE-8348
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.95.0
> Reporter: Jean-Daniel Cryans
> Assignee: rajeshbabu
> Priority: Blocker
> Fix For: 0.96.0
>
> Attachments: HBASE-8348-approach-2.patch,
> HBASE-8348-approach-2-v2.1.patch, HBASE-8348-approach-2-v2.2.patch,
> HBASE-8348-approach-3.patch, HBASE-8348_trunk.patch,
> HBASE-8348_trunk_v2.patch, HBASE-8348_trunk_v3.patch
>
>
> Currently, migration works but there's still a couple of rough edges:
> - HBASE-8045 finished the .META. migration but didn't remove ROOT, so it's
> still on the filesystem.
> - Data in ZK needs to be removed manually. Either we fix up the data in ZK
> or we delete it ourselves.
> - TestMetaMigrationRemovingHTD has a testMetaUpdatedFlagInROOT method, but
> ROOT is gone now.
> Elliott was also mentioning that we could have "hbase migrate" do the HFileV1
> checks, clear ZK, remove ROOT, etc.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
