[ 
https://issues.apache.org/jira/browse/HBASE-3833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13035655#comment-13035655
 ] 

Vishal Kathuria commented on HBASE-3833:
----------------------------------------

Thanks for the review and the suggestions stack. 

I didn't know about the JUNit test timeout - you are right, I don't need to do 
limit the loop.

Regarding destination for the patch - I'll follow up with dhruba to figure out 
the desired destination and make appropriate changes to remove the deprecated 
stuff. 

"I'm not clear on how a decommissioned node, once added to the excludes, is 
cleared of its regions. Did I miss it?"
When the node list is refreshed and a node shows up in the decommissioned list, 
ServerManager::refreshNodes() calls 
ServerManager::decommissionServer(serverInfo) to start the decomissioning 
process.

Thanks!
Vishal



> ability to support includes/excludes list in Hbase
> --------------------------------------------------
>
>                 Key: HBASE-3833
>                 URL: https://issues.apache.org/jira/browse/HBASE-3833
>             Project: HBase
>          Issue Type: Improvement
>          Components: client, regionserver
>    Affects Versions: 0.90.2
>            Reporter: dhruba borthakur
>            Assignee: dhruba borthakur
>         Attachments: excl-patch.txt, excl-patch.txt
>
>
> An HBase cluster currently does not have the ability to specify that the 
> master should accept regionservers only from a specified list. This helps 
> preventing administrative errors where the same machine could be included in 
> two clusters. It also allows the administrator to easily remove un-ssh-able 
> machines from the cluster.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to