[ 
https://issues.apache.org/jira/browse/HBASE-8348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13747949#comment-13747949
 ] 

Himanshu Vashishtha commented on HBASE-8348:
--------------------------------------------

bq. and the dir is used when you check, right? Not when you execute?
Yes.

bq. mutually exclusive
I made it to handle both (just in case) such that if a user gives both, then 
check will be evaluated first, and then the execute. 
In case there is any error in check (a HFileV1 is present, for example), then 
it will not go to the execute step.

bq. If someone wants to run the v1 check against a running 0.94 instance, how 
do they do that now? They do it out of a 0.96 binary?
Yes. They could point to any directory using -dir option while checking.

bq. In the process check, do we check for zk? If zk is down, how does it get 
'udated'?
Yes, a running zk and hdfs is required.

Sorry if the usage is still not clear enough. I was thinking of writing a 
little help section in the ref guide to help admins.
                
> Polish the migration to 0.96
> ----------------------------
>
>                 Key: HBASE-8348
>                 URL: https://issues.apache.org/jira/browse/HBASE-8348
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.95.0
>            Reporter: Jean-Daniel Cryans
>            Assignee: rajeshbabu
>            Priority: Blocker
>             Fix For: 0.96.0
>
>         Attachments: HBASE-8348-approach-2.patch, 
> HBASE-8348-approach-2-v2.1.patch, HBASE-8348-approach-2-v2.2.patch, 
> HBASE-8348-approach-2-v2.3.patch, HBASE-8348-approach-2-v2.4.patch, 
> HBASE-8348-approach-3.patch, HBASE-8348_trunk.patch, 
> HBASE-8348_trunk_v2.patch, HBASE-8348_trunk_v3.patch, log, log-2
>
>
> Currently, migration works but there's still a couple of rough edges:
>  - HBASE-8045 finished the .META. migration but didn't remove ROOT, so it's 
> still on the filesystem.
>  - Data in ZK needs to be removed manually. Either we fix up the data in ZK 
> or we delete it ourselves.
>  - TestMetaMigrationRemovingHTD has a testMetaUpdatedFlagInROOT method, but 
> ROOT is gone now.
> Elliott was also mentioning that we could have "hbase migrate" do the HFileV1 
> checks, clear ZK, remove ROOT, etc.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to