[
https://issues.apache.org/jira/browse/HBASE-9116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13749336#comment-13749336
]
Nicolas Liochon commented on HBASE-9116:
----------------------------------------
I haven't run the tool, just read the code.
Seems ok, some nits:
bq. long startTime = System.currentTimeMillis();
Please use EnvironmentEdge
bq. * Copyright 2011 The Apache Software Foundation
No date anymore on licenses
bq. // TODO Auto-generated method stub
Should be removed if we're fine with the standard generation
> Add a view/edit tool for favored node mappings for regions
> ----------------------------------------------------------
>
> Key: HBASE-9116
> URL: https://issues.apache.org/jira/browse/HBASE-9116
> Project: HBase
> Issue Type: Improvement
> Components: Region Assignment
> Affects Versions: 0.95.0
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.96.0
>
> Attachments: 9116-1.txt, 9116-2.txt, 9116-2.txt, 9116-2.txt,
> 9116-3.txt
>
>
> Add a tool that one can run offline to view the favored node mappings for
> regions, and also fix the mappings if needed. Such a tool exists in the
> 0.89-fb branch. Will port it over to trunk/0.95.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
