[
https://issues.apache.org/jira/browse/HBASE-9116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13750916#comment-13750916
]
Nick Dimiduk commented on HBASE-9116:
-------------------------------------
Is there a reason for SnapshotOfRegionAssignmentFromMeta to separate
construction from initialization? Why not just call initialize() at the end of
the constructor body?
Is it worth RegionPlacementMaintainer extending AbstractHBaseTool?
Is this necessary -- can you instead separate out "case 2" as a second test?
{noformat}
- @Test(timeout = 180000)
+ @Test(timeout = 1800000)
public void testRegionPlacement() throws Exception {
{noformat}
FYI, it looks like this patch has some noise in it:
{noformat}
$ git apply 9116-5.txt
9116-5.txt:31: trailing whitespace.
java.util.List<org.apache.hadoop.hbase.protobuf.generated.AdminProtos.OpenRegionRequest.RegionOpenInfo>
9116-5.txt:44: trailing whitespace.
java.util.List<? extends
org.apache.hadoop.hbase.protobuf.generated.AdminProtos.OpenRegionRequest.RegionOpenInfoOrBuilder>
9116-5.txt:165: trailing whitespace.
public java.util.List<? extends
org.apache.hadoop.hbase.protobuf.generated.AdminProtos.OpenRegionRequest.RegionOpenInfoOrBuilder>
9116-5.txt:453: trailing whitespace.
updateRegionInfoBuilder_ =
9116-5.txt:468: trailing whitespace.
warning: squelched 15 whitespace errors
warning: 20 lines add whitespace errors.
{noformat}
> Add a view/edit tool for favored node mappings for regions
> ----------------------------------------------------------
>
> Key: HBASE-9116
> URL: https://issues.apache.org/jira/browse/HBASE-9116
> Project: HBase
> Issue Type: Improvement
> Components: Region Assignment
> Affects Versions: 0.95.0
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.96.0
>
> Attachments: 9116-1.txt, 9116-2.txt, 9116-2.txt, 9116-2.txt,
> 9116-3.txt, 9116-4.txt, 9116-5.txt
>
>
> Add a tool that one can run offline to view the favored node mappings for
> regions, and also fix the mappings if needed. Such a tool exists in the
> 0.89-fb branch. Will port it over to trunk/0.95.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
