[ 
https://issues.apache.org/jira/browse/HBASE-8410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13763515#comment-13763515
 ] 

stack commented on HBASE-8410:
------------------------------

I took a look.

The Interface is named NamespaceDescriptorRetriever.  A related, more general 
Interface for dealing with TableDescriptors is called TableDescriptors.  For 
consistency should this Interface not be called NamespaceDescriptors?

Does it belong in hbase-common rather than in hbase-server?

The method list returns a Set which is a little disorientating.  In 
TableDescriptors, the equivalent method is named getAll.

NamespaceController seems a too general name for a class that does resource 
checking.  NamespaceResourceChecker or NamespaceAuditor?

Why is this not package private?  +public class NamespaceTableAndRegionInfo {  
Is not used in this package only?

How often do we do this: getNamespaceTableAndRegionInfo ?

We start this in the RS.  Do we have to stop it when done?

+    this.zkNamespaceManager.start();

Do we have to add this to RegionServerServices? getNamespaceDescRetriever ?

Does the ZKNamespaceManager in RS do anything?  Does it have to be on the RS?  
Can't master do necessary checks?

Thanks.
                
> Basic quota support for namespaces
> ----------------------------------
>
>                 Key: HBASE-8410
>                 URL: https://issues.apache.org/jira/browse/HBASE-8410
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Francis Liu
>            Assignee: Vandana Ayyalasomayajula
>         Attachments: HBASE_8410_1_trunk.patch, HBASE_8410.patch, 
> HBASE-8410_trunk_2.patch, HBASE-8410_trunk_3.patch, HBASE-8410_trunk_4.patch, 
> HBASE-8410_trunk_4.patch, HBASE-8410_trunk_5.patch, HBASE-8410_trunk_6.patch, 
> HBASE-8410_trunk_7.patch
>
>
> This task involves creating an observer which provides basic quota support to 
> namespaces in terms of (1) number of tables and (2) number of regions. The 
> quota support can be enabled by setting:
> <property>
>     <name>hbase.coprocessor.region.classes</name>
>     <value>org.apache.hadoop.hbase.namespace.NamespaceController</value>
> </property>
> <property>
>     <name>hbase.coprocessor.master.classes</name>
>     <value>org.apache.hadoop.hbase.namespace.NamespaceController</value>
> </property>
> in the hbase-site.xml.
> To add quotas to namespace, while creating namespace properties need to be 
> added.
> Examples:
> 1. namespace_create 'ns1', {'hbase.namespace.quota.maxregion'=>'10'}
> 2. 1. namespace_create 'ns2', {'hbase.namespace.quota.maxtables'=>'2'}, 
> {'hbase.namespace.quota.maxregion'=>'5'}
> The quotas can be modified/added to namespace at any point of time. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to