[
https://issues.apache.org/jira/browse/HBASE-9480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13763528#comment-13763528
]
Jeffrey Zhong commented on HBASE-9480:
--------------------------------------
Yeah. In [~devaraj] patch, he only touched one place how about removing the
similar one above in the same unassign function like the following and keep the
"return" because there is no need to retry. Thanks.
{code}
for (int i = 1; i <= this.maximumAttempts; i++) {
// ClosedRegionhandler can remove the server from this.regions
if (!serverManager.isServerOnline(server)) {
- if (transitionInZK) {
- // delete the node. if no node exists need not bother.
- deleteClosingOrClosedNode(region);
- }
- if (state != null) {
- regionOffline(region);
- }
+ // SSH will transition the region
return;
}
try {
@@ -1772,12 +1766,8 @@ public class AssignmentManager extends ZooKeeperListener
{
}
if (t instanceof NotServingRegionException
|| t instanceof RegionServerStoppedException) {
- if (transitionInZK) {
- deleteClosingOrClosedNode(region);
- }
- if (state != null) {
- regionOffline(region);
- }
+ LOG.warn("sendRegionClose failed because " + region.getEncodedName()
+ " isn't on server"
+ + server, t);
return;
{code}
> Regions are unexpectedly made offline in certain failure conditions
> -------------------------------------------------------------------
>
> Key: HBASE-9480
> URL: https://issues.apache.org/jira/browse/HBASE-9480
> Project: HBase
> Issue Type: Bug
> Reporter: Devaraj Das
> Priority: Critical
> Fix For: 0.96.0
>
> Attachments: 9480-1.txt
>
>
> Came across this issue (HBASE-9338 test):
> 1. Client issues a request to move a region from ServerA to ServerB
> 2. ServerA is compacting that region and doesn't close region immediately. In
> fact, it takes a while to complete the request.
> 3. The master in the meantime, sends another close request.
> 4. ServerA sends it a NotServingRegionException
> 5. Master handles the exception, deletes the znode, and invokes regionOffline
> for the said region.
> 6. ServerA fails to operate on ZK in the CloseRegionHandler since the node is
> deleted.
> The region is permanently offline.
> There are potentially other situations where when a RegionServer is offline
> and the client asks for a region move off from that server, the master makes
> the region offline.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
