[
https://issues.apache.org/jira/browse/HBASE-9101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13764543#comment-13764543
]
stack commented on HBASE-9101:
------------------------------
It is getting closer.
It is perverse that RpcServer knows about RegionServerServices. That is
broken. Pass in a Priority interface that has one method in it that returns
'level'. RegionServerServices can implement it too if needed. I can do this
mod to your patch if you would like.
Otherwise it looks good to me.
> Addendum to pluggable RpcScheduler
> ----------------------------------
>
> Key: HBASE-9101
> URL: https://issues.apache.org/jira/browse/HBASE-9101
> Project: HBase
> Issue Type: Improvement
> Components: IPC/RPC
> Reporter: Chao Shi
> Assignee: Chao Shi
> Fix For: 0.98.0
>
> Attachments: hbase-9101.patch, hbase-9101-v2.patch,
> hbase-9101-v3.patch, hbase-9101-v4.patch
>
>
> This patch fixes the review comments from [~stack] and a small fix:
> - Make RpcScheduler fully pluggable. One can write his/her own implementation
> and add it to classpath and specify it by config
> "hbase.region.server.rpc.scheduler.factory.class".
> - Add unit tests and fix that RpcScheduler.stop is not called (discovered by
> tests)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
