[
https://issues.apache.org/jira/browse/HBASE-9101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13763087#comment-13763087
]
Chao Shi commented on HBASE-9101:
---------------------------------
oops.. sorry for not updating this ticket for a while. (my mailbox doesn't
receive JIRA updates for unknown reasons).
bq.
Do you have to pass in an HRegionServer? ... Could it be an instance of Server?
Or RegionServerServices
The reason is that the RpcScheduler constructor needs QosFunction (which is
member of HRegionServer). I see this is not clean, but don't know if I can add
it to the interface RegionServerServices. Any ideas?
bq.
Why have this constant ... up in HConstants and not in HRegionServer or in the
scheduler Interface itself
Fixed.
bq.
We really should add a comment in HConstants that generally constants shouldn't
go there, unless referenced by a lot of different things.
Fixed.
> Addendum to pluggable RpcScheduler
> ----------------------------------
>
> Key: HBASE-9101
> URL: https://issues.apache.org/jira/browse/HBASE-9101
> Project: HBase
> Issue Type: Improvement
> Components: IPC/RPC
> Reporter: Chao Shi
> Assignee: Chao Shi
> Fix For: 0.98.0
>
> Attachments: hbase-9101.patch, hbase-9101-v2.patch
>
>
> This patch fixes the review comments from [~stack] and a small fix:
> - Make RpcScheduler fully pluggable. One can write his/her own implementation
> and add it to classpath and specify it by config
> "hbase.region.server.rpc.scheduler.factory.class".
> - Add unit tests and fix that RpcScheduler.stop is not called (discovered by
> tests)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
