[
https://issues.apache.org/jira/browse/HBASE-9505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13766773#comment-13766773
]
Nick Dimiduk commented on HBASE-9505:
-------------------------------------
Reviewing patch v3:
{noformat}
- if (!conf.getBoolean(HConstants.REPLICATION_ENABLE_KEY, false)) {
+ if (!conf.getBoolean(HConstants.REPLICATION_ENABLE_KEY, true)) {
{noformat}
You check this 3 times. Might as well promote the default value to HConstants.
{noformat}
- if (kv.matchingFamily(WALEdit.METAFAMILY)) continue;
+ // unit tests have a tendency to pass incorrect htds, prevent NPEs by
checking if null
+ if (kv.matchingFamily(WALEdit.METAFAMILY) || htd.getFamily(family) ==
null) continue;
{noformat}
I'd prefer to see the tests fixed rather than silently ignoring what otherwise
would be a bug.
> Enable replication by default
> -----------------------------
>
> Key: HBASE-9505
> URL: https://issues.apache.org/jira/browse/HBASE-9505
> Project: HBase
> Issue Type: Task
> Reporter: Jean-Daniel Cryans
> Assignee: Jean-Daniel Cryans
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: HBASE-9505.patch, HBASE-9505-v2.patch,
> HBASE-9505-v3.patch
>
>
> Wondering if we can enable replication by default, going to attach a patch
> that does it and get a QA run.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
